Removing outdated note about Windows support for dynamic_linking #628
Conversation
|
Using the dynamic_linking feature still doesn't work for me on windows 10. I still get the issues mentioned in this thread bevyengine/bevy#1110 I'm surprised it works for anyone on windows honestly. Did you test it with default features disabled? |
|
To clarify a bit, it does work when enabling the optimization like mentioned in the linked thread, but it seems wrong to not mention to users that they need to do additional configurations to get it to work. |
|
Perhaps that is why. I did do the optimizations. Ok, so it seems like it isn't 'broken' completely (which is the way the previous text read to me).. seems like it needs a bit more clarification that it will only work on windows when enabling the optimizations? |
This is a valuable enough feature that I think we should let Windows users know that there is a path available. I agree that we should just clarify what that path is. |
Co-authored-by: Paul Hansen <mail@paul.rs>
|
@paul-hansen Applied your suggested edits. |
I tested the dynamic linking on Windows 11 and it works. I also heard from others in the Discord chats that it seems to be a resolved issue. Thus a small PR to update the docs to reflect that.
Here is the relevant discussion with Alice in the General room on Discord where they call out that they believe it is fixed: https://discord.com/channels/691052431525675048/691052431974465548/1103445630237540362